Skip to content

[FC-0009] feat: Add subsection grading policy mismatch validation - #32813

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:yusuf-musleh/subsection-grading-policy-mismatch-validation
Jul 27, 2023
Merged

[FC-0009] feat: Add subsection grading policy mismatch validation#32813
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:yusuf-musleh/subsection-grading-policy-mismatch-validation

Conversation

@yusuf-musleh

@yusuf-musleh yusuf-musleh commented Jul 23, 2023 •
edited by bradenmacdonald
Loading

Copy link
Copy Markdown
Member

Description

This implements openedx/modular-learning#20, it adds validation for the grading assignment and grading policy in subsections, showing a warning in Studio if there is a mismatch.

Testing instructions

  1. Login to Studio: http://localhost:18010/
  2. Click on an existing course or create a new one
  3. Navigate to the Grading Settings of the selected course: eg: http://localhost:18010/settings/grading/<course_key>
  4. Create a new Assignment Type by click on "+ New Assignment Type"
    1. Give it a name and weight
    2. Save
  5. Navigate back to the Course Outline page in Studio: http://localhost:18010/course/<course_key>
  6. Click configure on a Subsection and select the newly created Grading Assignment type from the "Grade as" dropdown menu in the Subsection Settings modal, and save it
  7. After the change is reflected, navigate back to the Grading Settings http://localhost:18010/settings/grading/<course_key>
    1. Delete the newly created Grading Assignment Type
    2. Save
  8. Navigate back to the Course Outline page you should see a warning message under the subsection that looks like this:
    Screen Shot 2023-07-23 at 2 00 01 PM

Private ref: FAL-3464

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 23, 2023
@openedx-webhooks

openedx-webhooks commented Jul 23, 2023

Copy link
Copy Markdown

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211

mphilbrick211 commented Jul 24, 2023

Copy link
Copy Markdown

Hi @yusuf-musleh! Is this ready for review?

@bradenmacdonald bradenmacdonald changed the title feat: Add subsection grading policy mismatch validation [FC-0009] feat: Add subsection grading policy mismatch validation Jul 24, 2023
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Jul 24, 2023
@bradenmacdonald
bradenmacdonald self-requested a review July 24, 2023 19:27
@bradenmacdonald

bradenmacdonald commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

@mphilbrick211 This is part of FC-0009 actually, and I can review it.

@yusuf-musleh
yusuf-musleh force-pushed the yusuf-musleh/subsection-grading-policy-mismatch-validation branch from a413c51 to bd03f13 Compare July 25, 2023 08:00
@yusuf-musleh

yusuf-musleh commented Jul 25, 2023

Copy link
Copy Markdown
Member Author

@mphilbrick211 @bradenmacdonald yes, its ready for review.

bradenmacdonald
bradenmacdonald approved these changes Jul 25, 2023
View reviewed changes

@bradenmacdonald bradenmacdonald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks! Nice work. I just had one question but this is good to go.

  • I tested this: in Studio, as described
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation: n/a

Comment thread cms/templates/js/course-outline.underscore Outdated
@yusuf-musleh
yusuf-musleh force-pushed the yusuf-musleh/subsection-grading-policy-mismatch-validation branch 3 times, most recently from d37293b to 88c2885 Compare July 27, 2023 11:07
@yusuf-musleh
feat: Add subsection grading policy mismatch validation
3d9e6d2 
Adds validation for the grading assignment and grading policy, showing a
warning in Studio if there is a mismatch.
@yusuf-musleh
yusuf-musleh force-pushed the yusuf-musleh/subsection-grading-policy-mismatch-validation branch from 88c2885 to 3d9e6d2 Compare July 27, 2023 15:30
@bradenmacdonald
bradenmacdonald merged commit 884d898 into openedx:master Jul 27, 2023
@bradenmacdonald
bradenmacdonald deleted the yusuf-musleh/subsection-grading-policy-mismatch-validation branch July 27, 2023 17:28
@edx-pipeline-bot

edx-pipeline-bot commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@kenclary kenclary mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees

No one assigned

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yusuf-musleh @openedx-webhooks @mphilbrick211 @bradenmacdonald @edx-pipeline-bot